The ranking, from best earner to weakest
Everyone has a pet profession, and most of the arguments about them are really arguments about taste. Here is my ordering anyway, based on how steadily each craft turns hours into coin on a Classic realm. Disagree freely; I have ranked them by earning power, not by fun, and where those two things split I will say so in the verdict.
A word on method before the list. I weighed each craft by how often someone wants its output, how many hours of upkeep it demands and how much you depend on luck. That makes the ranking boring but stable. I did not count the thrill of finding a rare recipe, because thrill does not fill a bank tab.
Two warnings for the sceptics. First, nobody on a busy realm gets rich from a single profession in a single sitting; the winners compound small, boring wins. Second, markets move. A craft that sits near the top today can slip when a lot of players pile in, so treat my order as a starting point for your own watching, not as scripture.
1. Mining
Ore is wanted by nearly every crafter on the server, and a miner never has to wait for a recipe to drop or a patron to show up. It is the closest thing the game has to a tap you can leave running, and veins in the open world never seem to go out of fashion. You will ride the same loop many times, so learn it well. Verdict: the most dependable earner, and dull exactly because it is dependable.

Practical tip while we are here: carry a few spare bag slots when you run a mining loop. Nothing is more irritating than watching a perfect vein glitter at you while your pockets are full of last night’s leftovers. Sell, mail or stash first, then ride.
2. Herbalism
Same story as mining, with a prettier commute. Alchemists need a constant supply and the Auction House knows it, so a full bag of the right flower is rarely a hard sell. The only weakness is competition: on a crowded route you will find the nodes already picked. Verdict: strong, a hair behind ore, and better if you pair it with a crafter.
3. Skinning
Leather sells because armor crafters cannot work without it, and you collect it while doing something else, which is the whole charm. Skinning turns every quest and every dungeon into a small side business without asking for a single extra step. Verdict: the best free income there is, so long as you were going to kill things anyway.
4. Enchanting
The ceiling is high and the floor is awkward. Rods and reagents cost effort, and the market depends on what players happen to be wearing that month. A patient enchanter who sits in a capital city and answers requests does very well. A hurried one gets frustrated. Verdict: excellent for the stubborn, miserable for everyone else.
Somewhere in here a different thought arrives. Plenty of players decide that none of this is how they want to spend their evenings, and a WoW Classic Gold offer is a route they choose instead of running a gathering circuit for hours. Fair enough; those same players still need to know which professions are worth leveling for the long run, so the ranking carries on below.
Before the next verdict, a small confession: I changed my mind on enchanting twice while writing this. The profession is a coin flip until you commit to a daily habit, and then it is suddenly serious money. If you are not going to check the market regularly, move it down three places in your own list.
5. Alchemy
Potions and flasks move constantly because raiders and dungeon groups burn through them like candles. You also need the herbs, so either gather them yourself or pay for them, and the margin depends entirely on how well you shop. Verdict: steady, rarely spectacular, and a natural partner for herbalism.
Another thing I want to say about the middle of this list: it is crowded on purpose. The difference between fifth and seventh is mostly how much you enjoy the loop, so choose by temperament. A restless player will outearn a patient one on a craft that rewards bursts, and the reverse is also true.

6. Tailoring
Bags are the reliable product. Everyone wants a bigger bag, and cloth is cheap to farm if you run dungeons. The recipes are easy to learn and the customers never quite run out. Verdict: quietly good, rarely thrilling, perfect if you hate waiting on rare drops.
7. Engineering
Gadgets are fun and the profit is patchy. A few items sell well, plenty gather dust, and some of the best are only useful for one narrow situation. Verdict: you do it for the toys and the occasional teleport trick, not for the coin.
8. Blacksmithing and leatherworking
Both depend on being the person with a rare plan or a well-timed stock of materials. There is plenty of demand and lots of competition. If you commit and chase the good patterns, the work pays. Verdict: fine if you commit, a drain if you dabble.
Where alchemy surprises people
Transmutes and specialty brews look like a side show until you notice how often a single clever recipe pays for the whole evening. Players who learn their specialty early tend to pull ahead of those who only brew the common potions. Verdict: underrated, and the reason I place it above tailoring despite the herbs.
9. Cooking, first aid and fishing
Nice companions, weak earners by themselves. Cooked food helps your own runs, bandages save the occasional wipe, and fish are a pleasant way to wind down by a lake. Verdict: do them for comfort, not for income.
If you only take one thing from this list, make it the pairing: a gathering profession with a crafting one gives you a product and a supply chain at once. Mining with blacksmithing, herbalism with alchemy, skinning with leatherworking. That combination beats any single entry above on its own, and it is the reason my top three are all things you do with your hands in the open world.
Pairings I would try first
If I were starting a fresh character this week I would take a gathering profession and its natural partner, then add a second crafter on a bank alt. The main handles the outdoor loop, the alt handles the quiet, repetitive work in a city. That split keeps both characters useful and means one bad evening does not stall the whole operation.
And a note for the hurried: a plain, patient profession plus steady Auction House habits beats any clever plan that depends on constant attention. Most gold in this game is made by routine, not by brilliance.
What I left out on purpose

Jewelcrafting-style fancy trades, rare recipe hunting and anything that needs a specific patch to make sense are skipped. They are fun, but this is a ranking for people who want steady coin from familiar tools. A reader who loves chasing rare patterns will rank things differently, and that is fine.
A word on bank alts
Whatever you pick, spare a character as a warehouse. A bank alt lets a gatherer hold ore, herbs and leather without clogging a main’s bags, and it makes posting stacks on the Auction House a slow, regular chore instead of a rush. Several of the crafts above get a lot better the moment you stop juggling space.
Last opinion, and the least popular: do not chase the ranking if you hate the work. A middling profession you enjoy will outearn a perfect one you abandon in week two.
